Ian Cook created ARROW-12886:
--------------------------------
Summary: [C++] Suppress vcpkg manifest disabled messages from
msbuild
Key: ARROW-12886
URL: https://issues.apache.org/jira/browse/ARROW-12886
Project: Apache Arrow
Issue Type: Improvement
Components: C++
Affects Versions: 4.0.0
Reporter: Ian Cook
Assignee: Ian Cook
When building the Arrow library _without_ using vcpkg on a Windows system that
has vcpkg installed, msbuild emits this message repeatedly during the build:
{quote}{{The vcpkg manifest was disabled, but we found a manifest file in
$(VcpkgManifestRoot). You may want to enable vcpkg manifests in your properties
page or pass /p:VcpkgEnableManifest=true to the msbuild invocation.}}
{quote}
This is of no consequence but it's annoying. See if we can configure the cmake
files to add {{/p:VcpkgEnableManifest=false}} to the compiler flags to suppress
this message when vcpkg is not being used for dependencies.
E.g. in {{SetupCxxFlags.cmake}}, add a conditional like this, including a
status message.
{code:java}
if(MSVC AND NOT ARROW_DEPENDENCY_SOURCE STREQUAL "VCPKG")
message(STATUS "Disabling the vcpkg manifest. To enable the vcpkg manifest,
set -DARROW_DEPENDENCY_SOURCE=VCPKG")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} /p:VcpkgEnableManifest=false")
endif(){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
