Ben Kietzman created ARROW-12953:
------------------------------------
Summary: [C++][Comptue] Refactor CheckScalar* to take Datum
arguments
Key: ARROW-12953
URL: https://issues.apache.org/jira/browse/ARROW-12953
Project: Apache Arrow
Issue Type: Improvement
Components: C++
Reporter: Ben Kietzman
CheckScalar*() are useful functions, but expressing all permutations of input
shape in the public signature is overkill. We should consolidate these from
{code:cpp}
// Scalar - Scalar
void CheckScalarBinary(std::string func_name, std::shared_ptr<Scalar>
left_input,
std::shared_ptr<Scalar> right_input,
std::shared_ptr<Scalar> expected,
const FunctionOptions* options = nullptr);
// Array - Array
void CheckScalarBinary(std::string func_name, std::shared_ptr<Array> left_input,
std::shared_ptr<Array> right_input,
std::shared_ptr<Array> expected,
const FunctionOptions* options = nullptr);
// Array-Scalar
// Scalar-Array
// ...
{code}
to
{code:cpp}
void CheckScalarBinary(std::string func_name, Datum left_input,
Datum right_input,
Datum expected,
const FunctionOptions* options = nullptr);
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
