[
https://issues.apache.org/jira/browse/ARROW-13083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17364935#comment-17364935
]
Krisztian Szucs commented on ARROW-13083:
-----------------------------------------
> But if we want to be pedantic, then the version bump commit should be the
> first commit after the branching point
Ideally yes, though we usually create multiple release candidates. We would
need to first create a commit on master, then create the release branch from
the preceding commit for the first RC. For every subsequent RCs we would need
to cherry-pick commits (potentially required patches) from master and
regenerate the changelog again to the release branch, then merge that changelog
back to the master :)
It's more logical to me as well to tag the version bump commit, though the
in-between commits will have wrong versions generated (which we could live with
IMO).
> [Python] Wrong SCM version detection both in setup.py and crossbow
> ------------------------------------------------------------------
>
> Key: ARROW-13083
> URL: https://issues.apache.org/jira/browse/ARROW-13083
> Project: Apache Arrow
> Issue Type: Bug
> Components: Python
> Reporter: Krisztian Szucs
> Priority: Major
>
> Wanted to install nightly wheels for a rust integration test when I noticed
> that the nightly wheels get produced with base version 3.0.0.
> This is due to the recently changed release workflow. Now we're creating tags
> from release branches without a post rebase step, so setuptools_scm fails to
> find the correct version number on diverged branches.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
