David Li created ARROW-13197:
--------------------------------

             Summary: [C++] Optimize ArrayBuilder::AppendScalar
                 Key: ARROW-13197
                 URL: https://issues.apache.org/jira/browse/ARROW-13197
             Project: Apache Arrow
          Issue Type: Improvement
          Components: C++
            Reporter: David Li


{quote}Hmm, it looks like the implementation could be more optimized. When 
appending multiple scalars (or multiple times the same scalars), the required 
space could be reserved. Also, at least for primitive types, I would expect 
appending multiple scalars to be much more streamlined than this.

(it looks like such optimizations could be crafted more easily if 
{{AppendScalar}} was a bunch of virtual methods?)
{quote}

>From https://github.com/apache/arrow/pull/10579#issuecomment-869731284

Also, dictionary scalars aren't supported. You could imagine both appending a 
dictionary scalar to a regular builder (decoding the value) and appending a 
dictionary or regular scalar to a dictionary builder (encoding the value as 
necessary).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to