[
https://issues.apache.org/jira/browse/ARROW-13327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380135#comment-17380135
]
Eduardo Ponce edited comment on ARROW-13327 at 7/13/21, 7:52 PM:
-----------------------------------------------------------------
Actually, the description files (.pxd) contain the explicit types of the
function options' parameters (e.g., [SliceOptions in
libarrow.pxd|https://github.com/apache/arrow/blob/master/python/pyarrow/includes/libarrow.pxd#L1849-L1854]),
so I do not think it is necessary to add explicit types to the implementation
files (.pyx) as currently done for some cases (e.g., [SliceOptions in
_compute.pyx|https://github.com/apache/arrow/blob/master/python/pyarrow/_compute.pyx#L795-L803]).
was (Author: edponce):
Actually, the description files (e.g. libarrow.pxd) contains the explicit types
of the function options parameters, so I do not think it is necessary to add
explicit types to the implementation files.
> [Python] Improve consistency of explicit C++ types in PyArrow .pyx files
> ------------------------------------------------------------------------
>
> Key: ARROW-13327
> URL: https://issues.apache.org/jira/browse/ARROW-13327
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
> Reporter: Eduardo Ponce
> Priority: Minor
> Fix For: 6.0.0
>
>
> Cython files (.pyx) in PyArrow make inconsistent use of explicit C++ typing.
> Some methods/functions use explicit types for their parameters and others do
> not. We should establish a guideline of when an explicit C++ type is desired,
> and conform to this guideline. This issue should help establish these
> guideline rules and apply them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
