[ 
https://issues.apache.org/jira/browse/ARROW-13327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380495#comment-17380495
 ] 

Eduardo Ponce commented on ARROW-13327:
---------------------------------------

It seems that Cython considers pass-by-reference as default for *object* types. 
For example, *shared_ptr[T]* as *shared_ptr[T]&*. The ampersand seems to not be 
required. Nevertheless, it does supports and parses the ampersand so it is best 
to be consistent with C++ parameter types.

> [Python] Improve consistency of explicit C++ types in PyArrow files
> -------------------------------------------------------------------
>
>                 Key: ARROW-13327
>                 URL: https://issues.apache.org/jira/browse/ARROW-13327
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Python
>            Reporter: Eduardo Ponce
>            Assignee: Eduardo Ponce
>            Priority: Minor
>             Fix For: 6.0.0
>
>
> Cython files (.pyx) in PyArrow make inconsistent use of explicit C++ typing. 
> Some methods/functions use explicit types for their parameters and others do 
> not.
> Also, definition files (.pxd) are not consistent in the use of the reference 
> operator (&) and may not be up-to-date w.r.t. to C++ API.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to