[
https://issues.apache.org/jira/browse/ARROW-13384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383456#comment-17383456
]
Neal Richardson commented on ARROW-13384:
-----------------------------------------
IDK that this is GHA's fault actually, but in any case we should be able to get
the zstd version updated for autobrew. I'll look into it.
More generally though, is there a minimum version we require? Should that be
checked/enforced in cmake?
> [C++] homebrew-r-autobrew appears to use an old version of zstd
> ---------------------------------------------------------------
>
> Key: ARROW-13384
> URL: https://issues.apache.org/jira/browse/ARROW-13384
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: David Li
> Priority: Major
>
> This causes the build to fail as ZSTD_minCLevel() can't be found
> [https://github.com/ursacomputing/crossbow/runs/3105438383]
> {noformat}
> [ 54%] Building CXX object
> src/arrow/CMakeFiles/arrow_objlib.dir/csv/converter.cc.o
> cd
> /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/hbtmp/apache-arrow-20210719-2645-6nb4zw/build/src/arrow
> &&
> /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/build-apache-arrow/Library/Homebrew/shims/mac/super/clang++
> -DARROW_EXPORTING -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512
> -DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2
> -DARROW_JEMALLOC -DARROW_JEMALLOC_INCLUDE_DIR="" -DARROW_MIMALLOC
> -DARROW_WITH_BACKTRACE -DARROW_WITH_LZ4 -DARROW_WITH_RE2 -DARROW_WITH_SNAPPY
> -DARROW_WITH_TIMING_TESTS -DARROW_WITH_UTF8PROC -DARROW_WITH_ZLIB
> -DARROW_WITH_ZSTD -DURI_STATIC_BUILD -DUTF8PROC_STATIC
> -I/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/hbtmp/apache-arrow-20210719-2645-6nb4zw/build/src
>
> -I/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/hbtmp/apache-arrow-20210719-2645-6nb4zw/cpp/src
>
> -I/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/hbtmp/apache-arrow-20210719-2645-6nb4zw/cpp/src/generated
> -isystem
> /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/hbtmp/apache-arrow-20210719-2645-6nb4zw/cpp/thirdparty/flatbuffers/include
> -isystem
> /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/hbtmp/apache-arrow-20210719-2645-6nb4zw/build/jemalloc_ep-prefix/src
> -isystem
> /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/hbtmp/apache-arrow-20210719-2645-6nb4zw/build/mimalloc_ep/src/mimalloc_ep/lib/mimalloc-1.6/include
> -isystem
> /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/hbtmp/apache-arrow-20210719-2645-6nb4zw/build/rapidjson_ep/src/rapidjson_ep-install/include
> -isystem
> /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/hbtmp/apache-arrow-20210719-2645-6nb4zw/build/xsimd_ep/src/xsimd_ep-install/include
> -isystem
> /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/hbtmp/apache-arrow-20210719-2645-6nb4zw/build/re2_ep-install/include
> -isystem
> /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/hbtmp/apache-arrow-20210719-2645-6nb4zw/build/utf8proc_ep-install/include
> -isystem
> /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/hbtmp/apache-arrow-20210719-2645-6nb4zw/cpp/thirdparty/hadoop/include
> -Qunused-arguments -fcolor-diagnostics -O3 -DNDEBUG -Wall
> -Wno-unknown-Note-option -Wno-pass-failed -stdlib=libc++ -msse4.2 -DNDEBUG
> -isysroot
> /Applications/Xcode_12.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk
> -mmacosx-version-min=10.15 -fPIC -std=c++11 -o
> CMakeFiles/arrow_objlib.dir/csv/converter.cc.o -c
> /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/hbtmp/apache-arrow-20210719-2645-6nb4zw/cpp/src/arrow/csv/converter.cc
> /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/hbtmp/apache-arrow-20210719-2645-6nb4zw/cpp/src/arrow/util/compression_zstd.cc:231:59:
> error: use of undeclared identifier 'ZSTD_minCLevel'; did you mean
> 'ZSTD_maxCLevel'?
> int minimum_compression_level() const override { return ZSTD_minCLevel(); }
> ^~~~~~~~~~~~~~
> ZSTD_maxCLevel
> /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/build-apache-arrow/include/zstd.h:142:25:
> note: 'ZSTD_maxCLevel' declared here
> ZSTDLIB_API int ZSTD_maxCLevel(void); /*!< maximum
> compression level available */
> ^
> 1 error generated.
> make[2]: ***
> [src/arrow/CMakeFiles/arrow_objlib.dir/util/compression_zstd.cc.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [src/arrow/CMakeFiles/arrow_objlib.dir/all] Error 2
> make: *** [all] Error 2==> Formula
> Path:
> /Users/runner/work/crossbow/crossbow/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/tools/apache-arrow.rb
> ==> Configuration
> HOMEBREW_VERSION: >=1.7.1 (shallow or no git repository)
> ORIGIN: (none)
> HEAD: (none)
> Last commit: never
> Core tap ORIGIN: https://github.com/autobrew/homebrew-core
> Core tap HEAD: 73b60196102b25b6a91197210cad74ae7833b871
> Core tap last commit: 8 weeks ago
> HOMEBREW_PREFIX:
> /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/build-apache-arrow
> HOMEBREW_REPOSITORY:
> /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/build-apache-arrow
> HOMEBREW_CELLAR:
> /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/build-apache-arrow/Cellar
> HOMEBREW_CACHE: /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/
> HOMEBREW_TEMP: /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/hbtmp
> HOMEBREW_CASK_OPTS: --no-quarantine
> HOMEBREW_CLEANUP_PERIODIC_FULL_DAYS: 3650
> HOMEBREW_GIT: git
> HOMEBREW_NO_ANALYTICS: 1
> HOMEBREW_NO_AUTO_UPDATE: 1
> CPU: 3-core 64-bit ivybridge
> Homebrew Ruby: 2.3.7 =>
> /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/build-apache-arrow/Library/Homebrew/vendor/portable-ruby/2.3.7/bin/ruby
> Clang: 12.0 build 1200
> Git: 2.24.3 => /Applications/Xcode_12.4.app/Contents/Developer/usr/bin/git
> Curl: 7.64.1 => /usr/bin/curl
> Java: 14.0.2, 13.0.2, 12.0.2, 11.0.11, 1.8.0_292
> macOS: 10.15.7-x86_64
> CLT: 12.4.0.0.1.1610135815
> CLT headers: 12.4.0.0.1.1610135815
> Xcode: 12.4 => /Applications/Xcode_12.4.app/Contents/Developer
> Error: Error: apache-arrow HEAD-91a6ea4 did not build {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
