[
https://issues.apache.org/jira/browse/ARROW-13584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Sammons updated ARROW-13584:
--------------------------------
Description:
Using Typescript 4.3.5 I am seeing compilation issues in .ts files with the
compiler option `skipLibCheck` enabled, but the module is working fine (Node.js
14.16.0)
It's common for library .d.ts files to have incompatibility with the current
compilation either due to missing peer-types or compiler incompatibility. I
think both are happening here, but it doesn't matter for the consuming code as
long as the JS is compatible (which it is) - in these cases `skipLibCheck`
silences the .d.ts issues.
In this package that solution does not actually solve the compiler errors
because .ts files are shipped right alongside the .js and .d.ts files.
I have attached an example tsconfig.json and a log of the compiler errors I see.
was:
Using Typescript 4.3.5 I am seeing compilation issues in .ts files with the
compiler option `skipLibCheck` enabled, but the module is working fine (Node.js
14.16.0)
It's common for packages .d.ts files to have incompatibility with the current
compilation either due to missing peer-types or compiler incompatibility. I
think both are happening here, but it doesn't matter for the consuming code as
long as the JS is compatible (which it is) - in these cases `skipLibCheck`
silences the .d.ts issues.
In this package that solution does not actually solve the compiler errors
because .ts files are shipped right alongside the .js and .d.ts files.
I have attached an example tsconfig.json and a log of the compiler errors I see.
> Please do not include .ts files in npm artifacts alongside .d.ts
> ----------------------------------------------------------------
>
> Key: ARROW-13584
> URL: https://issues.apache.org/jira/browse/ARROW-13584
> Project: Apache Arrow
> Issue Type: Improvement
> Components: JavaScript
> Affects Versions: 5.0.0
> Environment: Windows 10, Typescript 4.3.5, [email protected],
> Node.js 14.16.0
> Reporter: Ben Sammons
> Priority: Minor
> Labels: TypeScript, arrow
> Attachments: log.txt, tsconfig.json
>
>
> Using Typescript 4.3.5 I am seeing compilation issues in .ts files with the
> compiler option `skipLibCheck` enabled, but the module is working fine
> (Node.js 14.16.0)
>
> It's common for library .d.ts files to have incompatibility with the current
> compilation either due to missing peer-types or compiler incompatibility. I
> think both are happening here, but it doesn't matter for the consuming code
> as long as the JS is compatible (which it is) - in these cases `skipLibCheck`
> silences the .d.ts issues.
>
> In this package that solution does not actually solve the compiler errors
> because .ts files are shipped right alongside the .js and .d.ts files.
>
> I have attached an example tsconfig.json and a log of the compiler errors I
> see.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
