Karl Dunkle Werner created ARROW-13768:
------------------------------------------

             Summary: [R] Allow JSON to be an optional component
                 Key: ARROW-13768
                 URL: https://issues.apache.org/jira/browse/ARROW-13768
             Project: Apache Arrow
          Issue Type: Task
          Components: R
    Affects Versions: 5.0.0
            Reporter: Karl Dunkle Werner


JSON support requires RapidJSON, a third-party dependency that might not always 
be available. Particularly for offline static builds (ARROW-12981), it would be 
nice to allow {{ARROW_JSON=OFF}}.

Here's the [relevant 
section|https://github.com/apache/arrow/blob/64bef2ad8d9cd2fea122cfa079f8ca3fea8cdf5d/cpp/cmake_modules/ThirdpartyToolchain.cmake#L290-L292]
 of {{ThirdpartyToolchain.cmake}}:
{code:none}
if(ARROW_JSON)
  set(ARROW_WITH_RAPIDJSON ON)
endif()
{code}
And the [relevant 
section|https://github.com/apache/arrow/blob/64bef2ad8d9cd2fea122cfa079f8ca3fea8cdf5d/r/inst/build_arrow_static.sh#L62]
 of the {{build_arrow_static.sh}} script.

As Neal 
[mentioned|https://github.com/apache/arrow/pull/11001#discussion_r696723923], 
there's more to do than just replacing {{-DARROW_JSON=ON}} with 
{{-DARROW_JSON=$\{ARROW_JSON:-ON}}}. "We'll have to conditionally build some of 
the bindings like we do with dataset and parquet, and we'll have to 
conditionally skip tests."



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to