[
https://issues.apache.org/jira/browse/ARROW-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429930#comment-17429930
]
Antoine Pitrou commented on ARROW-14361:
----------------------------------------
Not "MAX" because the max shouldn't be the default. Just "DEFAULT" then? (which
would select SSE4.2 on x86, NEON on ARM, and nothing on other archs...à.
> [C++] Define a MAX default value for ARROW_SIMD_LEVEL
> -----------------------------------------------------
>
> Key: ARROW-14361
> URL: https://issues.apache.org/jira/browse/ARROW-14361
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
> Reporter: Krisztian Szucs
> Priority: Major
> Fix For: 7.0.0
>
>
> In order to enable {{ARROW_HAVE_NEON}} CMake flag on ARM architectures
> {{ARROW_SIMD_LEVEL}} option must be set to not {{"NONE"}}, see
> https://github.com/apache/arrow/blob/master/cpp/cmake_modules/SetupCxxFlags.cmake#L444
> The default value for {{ARROW_SIMD_LEVEL}} is {{SSE4_2}} which is a bit
> misleading on ARM64, it should rather be {{NEON}} which is not listed as a
> valid option for {{ARROW_SIMD_LEVEL}}. We may have a {{"MAX"}} default value
> similarly to the {{ARROW_RUNTIME_SIMD_LEVEL}} option, see
> https://github.com/apache/arrow/blob/master/cpp/cmake_modules/DefineOptions.cmake#L115
> Original github comment:
> https://github.com/apache/arrow/pull/11433#discussion_r729852835
> cc [~yibocai] [~apitrou]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
