[
https://issues.apache.org/jira/browse/ARROW-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460898#comment-17460898
]
Antoine Pitrou commented on ARROW-7894:
---------------------------------------
We now have {{arrow/util/config.h.cmake}} which automatically exports the
definitions listed in that file, so it's just a matter of adding the desired
ones there.
> [C++] DefineOptions should invoke add_definitions
> -------------------------------------------------
>
> Key: ARROW-7894
> URL: https://issues.apache.org/jira/browse/ARROW-7894
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Affects Versions: 0.16.0
> Reporter: Ben Kietzman
> Assignee: Ben Kietzman
> Priority: Major
> Labels: pull-request-available
> Fix For: 7.0.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Several build options are mirrored as preprocessor definitions, for example
> \{{ARROW_JEMALLOC}}. This could be made more consistent by requiring that
> every option in DefineOptions should also define a preprocessor macro with
> {{add_definitions}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
