[ 
https://issues.apache.org/jira/browse/ARROW-12743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457009#comment-17457009
 ] 

Dragoș Moldovan-Grünfeld edited comment on ARROW-12743 at 1/6/22, 2:01 PM:
---------------------------------------------------------------------------

I think the roxygen2 version is recorded in a single place in DESCRIPTION (i.e. 
the {{RoxygenNote:}} field). I don't think CRAN checks parse that field and 
check what version of roxygen2 is available. If there is a mismatch in versions 
between the developer's local environment and DESCRIPTION {{devtools::check()}} 
with not re-document. Running {{devtools::document()}} in the same scenario 
will overwrite the {{RoxygenNote}} field.

We could use multiple "Config/Needs/..." fields and then install all 
dependencies with a single call to {{{}remotes::install_deps(){}}}.
{code:r}
install_deps(".", dependencies = c("soft", "Config/Needs/website", 
"Config/Needs/dev"))
{code}
, where {{"soft"}} is the equivalent of {{{}TRUE{}}}.

I think if someone has the development version of roxygen2 installed and they 
attempt to install dependencies, {{remotes}} will compare shas and will suggest 
and upgrade even if the version number is the same.


was (Author: dragosmg):
I think the roxygen2 version is recorded in a single place in DESCRIPTION (i.e. 
the {{RoxygenNote:}} field). I don't think CRAN checks parse that field and 
check what version of roxygen2 is available. If there is a mismatch in versions 
between the developer's local environment and DESCRIPTION {{devtools::check()}} 
with not re-document. Running {{devtools::document()}} in the same scenario 
will overwrite the {{RoxygenNote}} field.

We could use multiple "Config/Needs/..." fields and then install all 
dependencies with a single call to {{remotes::install_deps()}}.
{code:R}
install_deps(".", dependencies = c("soft", "Config/Needs/website", 
"Config/Needs/dev"))
{code} 

, where {{"soft"}} is the equivalent of {{TRUE}}.

I think it someone has the development version of roxygen2 installed and they 
attempt to install dependencies, {{remotes}} will compare shas and will suggest 
and upgrade even if the version number is the same.  

> [R] Add additional DESCRIPTION fields for dev dependencies and update docs 
> accordingly
> --------------------------------------------------------------------------------------
>
>                 Key: ARROW-12743
>                 URL: https://issues.apache.org/jira/browse/ARROW-12743
>             Project: Apache Arrow
>          Issue Type: Sub-task
>          Components: R
>            Reporter: Nicola Crane
>            Assignee: Dragoș Moldovan-Grünfeld
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 7.0.0
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Recent updates to the remotes package mean that additional fields can be 
> added to a package's DESCRIPTION and remotes functions can take the field as 
> a parameter and install these additional dependencies: 
> https://github.com/r-lib/remotes/blob/master/NEWS.md#new-functions-and-features
> We could update DESCRIPTION to use these fields and update the docs to use 
> this functionality of remotes instead of having separate references to 
> packages to install.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to