[
https://issues.apache.org/jira/browse/ARROW-15301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477096#comment-17477096
]
Dragoș Moldovan-Grünfeld commented on ARROW-15301:
--------------------------------------------------
My understanding of loading helpers was incorrect. I think
{{pkgload::testthat_source_test_helpers()}} sources all files that start with
the word {{helper}} from the test directory ({{tests/testthat}}).
> [R] Discussion: move testthat test helpers to R/test-helpers.R
> --------------------------------------------------------------
>
> Key: ARROW-15301
> URL: https://issues.apache.org/jira/browse/ARROW-15301
> Project: Apache Arrow
> Issue Type: Improvement
> Components: R
> Reporter: Dragoș Moldovan-Grünfeld
> Priority: Major
> Fix For: 8.0.0
>
>
> Would it make sense to have all custom expectations in {{R/}} , maybe
> {{R/test-helpers.R}} ? Reasons:
>
> * edit(added on 12/01/2022): probably the most important point is these
> files are source by {{devtools::load_all()}} and, thus, helper functions are
> available interactively.
> * easier for newbies to read a file and figure out what custom testthat
> helpers we have
> * easier to document
> * respects the testthat author's suggestion to have them there
> Currently we have 17 different custom expectations, all defined in different
> files.
> A follow-up thought: maybe move all helpers there ({{{}is.{}}}, {{{}as_{}}},
> {{{}compare_{}}}, {{verify}} etc).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
