[ 
https://issues.apache.org/jira/browse/ARROW-15571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487561#comment-17487561
 ] 

David Li edited comment on ARROW-15571 at 2/5/22, 9:07 PM:
-----------------------------------------------------------

Thanks for the code. That's not surprising, considering the elementwise min/max 
are variadic (and don't really specialize any cases). We could dispatch to the 
specialized case for when we have only two arguments, though (and we could add 
this benchmark to the upstream benchmarks to track the improvement).


was (Author: lidavidm):
Thanks for the code. That's not surprising, considering the elementwise min/max 
are variadic. We could dispatch to the specialized case for when we have only 
two arguments, though (and we could add this benchmark to the upstream 
benchmarks to track the improvement).

> [C++] Add min/max/sqrt scalar kernels to execution engine
> ---------------------------------------------------------
>
>                 Key: ARROW-15571
>                 URL: https://issues.apache.org/jira/browse/ARROW-15571
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Yaron Gvili
>            Priority: Major
>              Labels: kernel, pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The list of execution engine's scalar kernels currently available in 
> `cpp/src/arrow/compute/kernels/scalar_arithmetic.cc` does not cover the 
> common minimum, maximum, and square-root functions.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to