[
https://issues.apache.org/jira/browse/ARROW-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500322#comment-17500322
]
Pradeep Garigipati edited comment on ARROW-14134 at 3/2/22, 6:18 PM:
---------------------------------------------------------------------
After brain storming (with [~edponce]) for a bit on generator dispatchers in
[codegen_internal.h|https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/codegen_internal.h#L988]
source file, we have created a [google
document|https://docs.google.com/document/d/1xIwOGSsQiykGvmX1bK3iRWDbJagGeAC0-4rH1xgVMBI/edit?usp=sharing]
outlining a proposal to refactor the names of generator dispatchers to follow
a systematic pattern.
We are sharing the document here to take the discussion further with community
feedback.
Thank you.
[~lidavidm]
was (Author: pradeepgarigipati):
After brain storming (with [~edponce]) for a bit on generator dispatchers in
[codegen_internal.h|https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/codegen_internal.h#L988]
source file, we have created a [google
document|https://docs.google.com/document/d/1xIwOGSsQiykGvmX1bK3iRWDbJagGeAC0-4rH1xgVMBI/edit?usp=sharing]
outlining a proposal to refactor the names of generator dispatchers to follow
a systematic pattern.
We are sharing the document here to take the discussion further with community
feedback.
Thank you.
[~lidavidm]
> [C++][Compute] Standardize generator dispatchers
> ------------------------------------------------
>
> Key: ARROW-14134
> URL: https://issues.apache.org/jira/browse/ARROW-14134
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Eduardo Ponce
> Assignee: Pradeep Garigipati
> Priority: Trivial
> Labels: kernel
> Fix For: 8.0.0
>
>
> codegen_internal.h formally defines generator dispatchers and there are a few
> GDs defined in kernel source files. GDs should be categorized, commented, and
> renamed appropriately.
> Also, the documentation for GD should be updated since more capable GDs have
> been added.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
