[ 
https://issues.apache.org/jira/browse/ARROW-11090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503922#comment-17503922
 ] 

Rok Mihevc commented on ARROW-11090:
------------------------------------

Oh sorry, I missed that.

I'm unfamiliar with rollback. Would you say 
[this|https://github.com/tidyverse/lubridate/blob/main/tests/testthat/test-rollback.R]
 is a complete test of the feature? Could it be accomplished with subtract and 
floor/ceil (where floor/ceil would be adjusted to have change_on_boundary 
option)?

I would still propose opening a new ticket to discuss and track the work there 
and to give it visibility.

> [C++] Support temporal arithmetic ({time,date}{32,64}, timestamp, interval)
> ---------------------------------------------------------------------------
>
>                 Key: ARROW-11090
>                 URL: https://issues.apache.org/jira/browse/ARROW-11090
>             Project: Apache Arrow
>          Issue Type: New Feature
>          Components: C++
>            Reporter: Jonathan Keane
>            Priority: Major
>              Labels: kernel
>             Fix For: 8.0.0
>
>
> [It appears that only subtract on two timestamps is currently 
> supported|https://github.com/apache/arrow/commit/dd94a5809b56b32fe2fb538f688bf568d9642e3b]
>  when there is more supported, we should include support for that in R.
>  
> This should also cover the ability to do with and without rollback (so have 
> the ability to do e.g. 2021-03-30 minus 1 month and either get a null back, 
> or 2021-02-28), plus the ability to specify whether to rollback to the first 
> or last, and whether to preserve or rest the time.)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to