[
https://issues.apache.org/jira/browse/ARROW-15975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Li resolved ARROW-15975.
------------------------------
Resolution: Fixed
Issue resolved by pull request 12717
[https://github.com/apache/arrow/pull/12717]
> [C++] Document VisitArrayInline and type traits
> -----------------------------------------------
>
> Key: ARROW-15975
> URL: https://issues.apache.org/jira/browse/ARROW-15975
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Affects Versions: 7.0.0
> Reporter: Will Jones
> Assignee: Will Jones
> Priority: Major
> Labels: pull-request-available
> Fix For: 8.0.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> In ARROW-15952, we documented the {{ArrayVisitor}} and {{TypeVisitor}}
> classes. But as I discovered in [a cookbook
> PR|https://github.com/apache/arrow-cookbook/pull/166], you can't subclass
> these abstract visitors _and_ use type traits. Now I know why most visitor
> implementations within of Arrow don't subclasses these.
> We should instead suggest users simply use the {{VisitArrayInline}} and
> {{VisitTypeInline}} with their visitors, and ignore the {{ArrayVisitor}} and
> {{TypeVisitor}} classes and associated {{Accept()}} methods. In fact, can we
> deprecate (or even remove) those? Do they add anything valuable?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
