[
https://issues.apache.org/jira/browse/ARROW-15678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524443#comment-17524443
]
Weston Pace commented on ARROW-15678:
-------------------------------------
We can perhaps add a static check that reports symbols outside the appropriate
namespace. We might need some configurable suppression. For example,
{{level_conversion_bmi2.cc.o}} would report:
{noformat}
0000000000000000 W arrow::util::ArrowLogBase&
arrow::util::ArrowLogBase::operator<< <char [51]>(char const (&) [51])
0000000000000000 W std::__cxx11::basic_string<char, std::char_traits<char>,
std::allocator<char> > arrow::util::StringBuilder<char const (&) [33]>(char
const (&) [33])
0000000000000000 W void arrow::util::StringBuilderRecursive<char const (&)
[33]>(std::ostream&, char const (&) [33])
0000000000000000 W arrow::util::detail::StringStreamWrapper::stream()
0000000000000000 W arrow::util::Voidify::operator&(arrow::util::ArrowLogBase&)
0000000000000000 W arrow::util::Voidify::Voidify()
0000000000000000 W arrow::bit_util::BytesForBits(long)
0000000000000000 W arrow::internal::FirstTimeBitmapWriter::AppendWord(unsigned
long, long)
0000000000000000 W arrow::internal::FirstTimeBitmapWriter::Finish()
0000000000000000 W
arrow::internal::FirstTimeBitmapWriter::FirstTimeBitmapWriter(unsigned char*,
long, long)
0000000000000000 W parquet::ParquetException::ParquetException<char const (&)
[33]>(char const (&) [33])
0000000000000000 W parquet::ParquetException::~ParquetException()
0000000000000000 W parquet::ParquetException::~ParquetException()
0000000000000000 W arrow::internal::FirstTimeBitmapWriter::position() const
0000000000000000 W parquet::ParquetException::what() const
0000000000000000 W std::exception::exception()
0000000000000000 W char const (&std::forward<char const (&)
[33]>(std::remove_reference<char const (&) [33]>::type&)) [33]
{noformat}
{{level_comparison_avx.cc.o}} looks to be in better shape:
{noformat}
0000000000000000 W short const& std::max<short>(short const&, short const&)
0000000000000000 W short const& std::min<short>(short const&, short const&)
{noformat}
But yes, if we have a better solution for this problem it might be safer.
> [C++][CI] a crossbow job with MinRelSize enabled
> ------------------------------------------------
>
> Key: ARROW-15678
> URL: https://issues.apache.org/jira/browse/ARROW-15678
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++, Continuous Integration
> Reporter: Jonathan Keane
> Priority: Major
> Labels: pull-request-available
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
