Dragoș Moldovan-Grünfeld created ARROW-16253:
------------------------------------------------

             Summary: [R] Helper function for casting from float to duration 
via int64() 
                 Key: ARROW-16253
                 URL: https://issues.apache.org/jira/browse/ARROW-16253
             Project: Apache Arrow
          Issue Type: Improvement
          Components: R
            Reporter: Dragoș Moldovan-Grünfeld


This logic is used in several places in {{R/dplyr-funcs-datetime.R}} and it 
would be great if we could separate it into a standalone helper function. The 
main purpose would be to indicate the float -> int64 -> duration casting chain 
is being used. 

https://github.com/apache/arrow/pull/12757/#discussion_r852389088 

{quote}I've seen this line in a few PRs recently — this is to get around the 
fact that we do not have float durations, yeah? I wonder if we should put that 
into a helper function. Not so much to save lines of code, but to encapsulate 
that we have this one workaround that we're using in all of these places.

Then if that workaround is not necessary (or if we find a better one) we can 
change it in one place. We don't need to do that here, but it would be good to 
make a Jira for that if we do want to.{quote}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to