[
https://issues.apache.org/jira/browse/ARROW-16424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ariana Villegas updated ARROW-16424:
------------------------------------
Summary: [C++] Update uri_path parsing in FromProto (was: [C++] Add
support for all options specified by
substrait::ReadRel::LocalFiles::FileOrFiles)
> [C++] Update uri_path parsing in FromProto
> ------------------------------------------
>
> Key: ARROW-16424
> URL: https://issues.apache.org/jira/browse/ARROW-16424
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Ariana Villegas
> Priority: Minor
> Labels: substrait
>
> FromProto function in {{arrow/engine/substrait/relation_internal.cc}} parse
> {{uri_path}} with {{string_view}} utilities. However this should be done with
> {{Uri}} class from {{arrow/util/uri.h.}}
> {code:c++}
> else if (util::string_view{path}.ends_with(".arrow")) {
> format = std::make_shared<dataset::IpcFileFormat>();
> } else if (util::string_view{path}.ends_with(".feather")) {
> format = std::make_shared<dataset::IpcFileFormat>();
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
