[
https://issues.apache.org/jira/browse/ARROW-16716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550653#comment-17550653
]
Ivan Chau edited comment on ARROW-16716 at 6/7/22 2:30 PM:
-----------------------------------------------------------
Hi [~icexelloss] , I wrote this part of the code corresponding to Weston's
review and have been running into some segfaults, I think pertaining to the
`ExecNode* input` parameter. Do you see any smells / errors in logic here?
*This is fixed now, just requires the addition of a sink.*
{code:java}
ASSERT_OK_AND_ASSIGN(auto sn, MakeExecNode("source", plan.get(), {},
SourceNodeOptions
{data.schema, data.gen(/*parallel=*/true, /*slow=*/false)}
)); // does source node need input?
ASSERT_OK_AND_ASSIGN(auto pn, MakeExecNode("project", plan.get(), {sn},
ProjectNodeOptions{{
expr,
}})); // {sn}, as the input is the source node
state.ResumeTiming();
pn->InputFinished(sn, num_batches); // segfault occurs on this line
for (auto b : data.batches)
{ pn->InputReceived(sn, b); } // segfault occurs on this line, if the other
faulting line is removed.
pn->finished();
{code}
was (Author: JIRAUSER290345):
Hi [~icexelloss] , I wrote this part of the code corresponding to Weston's
review and have been running into some segfaults, I think pertaining to the
`ExecNode* input` parameter. Do you see any smells / errors in logic here?
{code:java}
ASSERT_OK_AND_ASSIGN(auto sn, MakeExecNode("source", plan.get(), {},
SourceNodeOptions
{data.schema, data.gen(/*parallel=*/true, /*slow=*/false)}
)); // does source node need input?
ASSERT_OK_AND_ASSIGN(auto pn, MakeExecNode("project", plan.get(), {sn},
ProjectNodeOptions{{
expr,
}})); // {sn}, as the input is the source node
state.ResumeTiming();
pn->InputFinished(sn, num_batches); // segfault occurs on this line
for (auto b : data.batches)
{ pn->InputReceived(sn, b); } // segfault occurs on this line, if the other
faulting line is removed.
pn->finished();
{code}
> [Benchmarks] Create Projection benchmark for Acero
> --------------------------------------------------
>
> Key: ARROW-16716
> URL: https://issues.apache.org/jira/browse/ARROW-16716
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Benchmarking
> Reporter: Li Jin
> Priority: Major
> Labels: pull-request-available
> Attachments: out, out_expression
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
