[
https://issues.apache.org/jira/browse/ARROW-16786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kouhei Sutou updated ARROW-16786:
---------------------------------
Description:
https://arrow.apache.org/docs/developers/overview.html#pull-request-and-review
{quote}
A side effect of this way of merging is that your pull request will appear in
the GitHub interface to have been “closed without merge”. Do not be alarmed: if
you look at the bottom, you will see a message that says @user closed this in
$COMMIT. In the commit message of that commit, the merge tool adds the pull
request description, a link back to the pull request, and attribution to the
contributor and any co-authors.
{quote}
We have changed to use the "merge" feature of GitHub by ARROW-16602 to show
"merged" mark not "closed without merge" mark on GitHub. We should update the
note.
[~alenkaf] Do you want to work on this?
was:
https://arrow.apache.org/docs/developers/overview.html#pull-request-and-review
{noformat}
A side effect of this way of merging is that your pull request will appear in
the GitHub interface to have been “closed without merge”. Do not be alarmed: if
you look at the bottom, you will see a message that says @user closed this in
$COMMIT. In the commit message of that commit, the merge tool adds the pull
request description, a link back to the pull request, and attribution to the
contributor and any co-authors.
{noformat}
We have changed to use the "merge" feature of GitHub by ARROW-16602 to show
"merged" mark not "closed without merge" mark on GitHub. We should update the
note.
[~alenkaf] Do you want to work on this?
> [Docs] Update "closed without merge" in pull request note
> ---------------------------------------------------------
>
> Key: ARROW-16786
> URL: https://issues.apache.org/jira/browse/ARROW-16786
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Documentation
> Reporter: Kouhei Sutou
> Priority: Major
>
> https://arrow.apache.org/docs/developers/overview.html#pull-request-and-review
> {quote}
> A side effect of this way of merging is that your pull request will appear in
> the GitHub interface to have been “closed without merge”. Do not be alarmed:
> if you look at the bottom, you will see a message that says @user closed this
> in $COMMIT. In the commit message of that commit, the merge tool adds the
> pull request description, a link back to the pull request, and attribution to
> the contributor and any co-authors.
> {quote}
> We have changed to use the "merge" feature of GitHub by ARROW-16602 to show
> "merged" mark not "closed without merge" mark on GitHub. We should update the
> note.
> [~alenkaf] Do you want to work on this?
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
