[ 
https://issues.apache.org/jira/browse/ARROW-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554328#comment-17554328
 ] 

David Li commented on ARROW-16769:
----------------------------------

{{ABORT_NOT_OK}} is only being referenced as an example, and is not something 
we want to expose more broadly.

{{ARROW_WARN_NOT_OK}} would be a new macro, except I suppose it already exists, 
and does basically what is described here. So making it use the new 
{{Status::Warn}} instead seems reasonable to me. The mechanics are different: 
the current macro also stringifies the condition being checked, but in practice 
this doesn't really do anything much in the places it's used.

> [C++] Add Status::Warn()
> ------------------------
>
>                 Key: ARROW-16769
>                 URL: https://issues.apache.org/jira/browse/ARROW-16769
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Antoine Pitrou
>            Assignee: Aldrin M
>            Priority: Minor
>              Labels: good-first-issue
>             Fix For: 9.0.0
>
>
> We currently have {{Status::Abort()}} which gives an easy way to abort the 
> process with a meaningful message and detail.
> We should similarly add {{Status::Warn()}} that would simply print a warning 
> message of the error. Possible example use at 
> https://github.com/apache/arrow/pull/13315/files#diff-1256864b34a1b43082596ab5b16881702881ad06be8e1c157b47e1e6ac9ff5d2R160-R164
>  (together with {{StatusFromErrno}}).



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to