[
https://issues.apache.org/jira/browse/ARROW-16836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554619#comment-17554619
]
Antoine Pitrou edited comment on ARROW-16836 at 6/15/22 2:08 PM:
-----------------------------------------------------------------
We can simply warn if {{Close()}} returns a non-ok status, which should be
exceptional.
was (Author: pitrou):
We can simply warn if {{Close()}} returns a non-ok status.
> [C++] Have exported ArrowArrayStreams call RecordBatchReader::Close
> -------------------------------------------------------------------
>
> Key: ARROW-16836
> URL: https://issues.apache.org/jira/browse/ARROW-16836
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: David Li
> Priority: Major
>
> We added RecordBatchReader::Close(), should we have an exported
> ArrowArrayStream call this?
> The issue is that {{release()}} can't return errors. We could call
> {{Close()}} implicitly after the last batch if the user drains the
> ArrowArrayStream, and return any error there, but if they don't drain the
> stream (but call {{release}}) we'll have no way to return the error. (Or we
> could make an ABI break…)
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
