Jeroen van Straten created ARROW-16987:
------------------------------------------

             Summary: Refactor Substrait ToProto/FromProto to visitor pattern
                 Key: ARROW-16987
                 URL: https://issues.apache.org/jira/browse/ARROW-16987
             Project: Apache Arrow
          Issue Type: Improvement
          Components: C++
            Reporter: Jeroen van Straten


Currently, the conversion between Acero and Substrait plans is done ad hoc 
using various overloads of the ToProto and FromProto functions. Code quality 
may benefit from refactoring this to a visitor pattern, to make it more easy to 
track state (ExtensionSet), store conversion options, maybe make multiple 
implementations in the future via inheritance, etc.

It's probably better to do this sooner rather than later (if we're going to do 
it).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to