[ 
https://issues.apache.org/jira/browse/ARROW-15537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563665#comment-17563665
 ] 

Jeroen van Straten commented on ARROW-15537:
--------------------------------------------

I think the most reasonable thing to do here would be to make an extension type 
that includes a timezone string parameter, as made possible by 
[https://github.com/substrait-io/substrait/pull/196]. I advocated for 
parameterized type variations there as well for this reason, so we could just 
expose something like a with_timezone<str> variation on timestamp_tz to get 
e.g. timestamp[with_timezone<"UTC+1">]. IMO that would have made compatibility 
between consumers way easier, since all functions that can use the base 
variation of timestamp_tz would automatically support Arrow's variations that 
way. However, that change was rejected.

> [C++] Decide how we want to handle time zone strings in Substrait
> -----------------------------------------------------------------
>
>                 Key: ARROW-15537
>                 URL: https://issues.apache.org/jira/browse/ARROW-15537
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Weston Pace
>            Priority: Major
>              Labels: substrait
>
> Substrait timestamp_with_tz type does not include the timezone string as a 
> type parameter.  This may not be an issue.  Substrait functions that care 
> about the timezone of a column (e.g. strftime) will include the time zone 
> string as an argument.  So for purely consumption purposes we shouldn't have 
> any Substrait function / operation that depends on this timezone metadata.
> However, it may be an issue for export.  I'm creating this JIRA as a 
> placeholder for someone to think the problem through more fully and decide if 
> we need to do anything.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to