[
https://issues.apache.org/jira/browse/ARROW-17096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567874#comment-17567874
]
Antoine Pitrou commented on ARROW-17096:
----------------------------------------
I think this is a C++ bug. In {{aggregate_test.cc}}, this line is incorrect for
boolean inputs:
https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/aggregate_test.cc#L2541
There should be a {{CheckModes}} specialization for bools.
> pyarrow.compute.mode for boolean arrays does not return true when mixed with
> false
> ----------------------------------------------------------------------------------
>
> Key: ARROW-17096
> URL: https://issues.apache.org/jira/browse/ARROW-17096
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++, Python
> Affects Versions: 8.0.0
> Reporter: Matthew Roeschke
> Assignee: Yibo Cai
> Priority: Major
>
> {code:java}
> In [1]: import pyarrow.compute as pc
> In [2]: import pyarrow as pa
> In [3]: pa.__version__
> Out[3]: '8.0.0'
> In [4]: pc.mode(pa.array([True, True]))
> # Correct
> Out[4]:
> <pyarrow.lib.StructArray object at 0x1266d5c60>
> -- is_valid: all not null
> -- child 0 type: bool
> [
> true
> ]
> -- child 1 type: int64
> [
> 2
> ]
> # Incorrect
> In [5]: pc.mode(pa.array([True, False]), 2)
> Out[5]:
> <pyarrow.lib.StructArray object at 0x1262110c0>
> -- is_valid: all not null
> -- child 0 type: bool
> [
> false, # should be true
> false
> ]
> -- child 1 type: int64
> [
> 1,
> 1
> ] {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
