[
https://issues.apache.org/jira/browse/ARROW-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578180#comment-17578180
]
Aldrin Montana commented on ARROW-16894:
----------------------------------------
[~ichauster], I tried to run this benchmark but I see this error:
{code:bash}
./debug/arrow-compute-asof-join-benchmark
/Users/octalene/builds/arrow-dev/dev/gbenchmark_ep-prefix/src/gbenchmark_ep/src/benchmark_register.cc:314:
Args: Check `ArgsCnt() == -1 || ArgsCnt() == static_cast<int>(args.size())'
failed.
fish: Job 1, './debug/arrow-compute-asof-join…' terminated by signal SIGABRT
(Abort)
{code}
After I make the following change:
{code:c++}
--- a/cpp/src/arrow/compute/exec/asof_join_benchmark.cc
+++ b/cpp/src/arrow/compute/exec/asof_join_benchmark.cc
@@ -157,7 +157,7 @@ void SetArgs(benchmark::internal::Benchmark* bench) {
}
}
-BENCHMARK(AsOfJoinOverhead)->Apply(SetArgs);
+BENCHMARK(AsOfJoinOverhead);
} // namespace compute
} // namespace arrow
{code}
I see this error:
{code:bash}
***WARNING*** Library was built as DEBUG. Timings may be affected.
Assertion failed: (range_.size() > pos), function range, file benchmark.h, line
664.
fish: Job 1, './debug/arrow-compute-asof-join…' terminated by signal SIGABRT
(Abort)
{code}
I didn't read through the PR, but I just wanted to drop this note here in case
it's not just a me thing. I'm on an M1 mac mini, haven't tried on anything
else. And this should be on master branch. I suspect there's an extra thing to
do to run the benchmark (I assume there's a reason the *->Apply* breaks for
me), I just don't know what it is.
> [C++][Benchmarks] Create Asof Join Benchmark for Acero
> ------------------------------------------------------
>
> Key: ARROW-16894
> URL: https://issues.apache.org/jira/browse/ARROW-16894
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Ivan Chau
> Assignee: Ivan Chau
> Priority: Major
> Labels: pull-request-available
> Fix For: 10.0.0
>
> Time Spent: 13h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
