[
https://issues.apache.org/jira/browse/ARROW-16424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601550#comment-17601550
]
Aldrin Montana commented on ARROW-16424:
----------------------------------------
I have assigned this issue to myself. I tried to extend
[PR#13390|https://github.com/apache/arrow/pull/13390], but that became
complicated after I rebased.
I have created [PR#14071|https://github.com/apache/arrow/pull/14071] for
reference, but I will also try to coordinate with [~vibhatha] for ARROW-16855.
> [C++] Update uri_path parsing in FromProto
> ------------------------------------------
>
> Key: ARROW-16424
> URL: https://issues.apache.org/jira/browse/ARROW-16424
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Ariana Villegas
> Assignee: Aldrin Montana
> Priority: Minor
> Labels: pull-request-available, substrait
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> FromProto function in {{arrow/engine/substrait/relation_internal.cc}} parse
> {{uri_path}} with {{string_view}} utilities. However this should be done with
> {{Uri}} class from {{arrow/util/uri.h.}}
> {code:c++}
> else if (util::string_view{path}.ends_with(".arrow")) {
> format = std::make_shared<dataset::IpcFileFormat>();
> } else if (util::string_view{path}.ends_with(".feather")) {
> format = std::make_shared<dataset::IpcFileFormat>();
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
