[ 
https://issues.apache.org/jira/browse/ARROW-6459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601691#comment-17601691
 ] 

Alenka Frim commented on ARROW-6459:
------------------------------------

_Additional question me and Joris have is about the need for Python for linting 
purposes in the Arrow C++._

There is still a part of the {{arrow/cpp/CMakeLists.txt}} code that needs 
Python for linting targets
[https://github.com/apache/arrow/blob/47314c3999d7b7a7f9167c6ed6793da756c411a1/cpp/CMakeLists.txt#L179-L192]

There are several python files inĀ {{arrow/cpp/build-support/}}
[https://github.com/apache/arrow/tree/47314c3999d7b7a7f9167c6ed6793da756c411a1/cpp/build-support]

One of them for example is called from a cmake target in {{cpp/CMakeLists.txt}}
[https://github.com/apache/arrow/blob/47314c3999d7b7a7f9167c6ed6793da756c411a1/cpp/CMakeLists.txt#L259-L278]

These files can still be useful for development in general. *So the question is 
whether we want to keep Python included for the reason of linting cpp code?*

> [C++] Remove "python" from conda_env_cpp.txt
> --------------------------------------------
>
>                 Key: ARROW-6459
>                 URL: https://issues.apache.org/jira/browse/ARROW-6459
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Wes McKinney
>            Priority: Minor
>
> I'm not sure why "python" is in this dependency file -- if it is used to 
> maintain a toolchain external to a particular Python environment then it 
> confuses CMake like
> {code}
> CMake Warning at cmake_modules/BuildUtils.cmake:529 (add_executable):
>   Cannot generate a safe runtime search path for target arrow-python-test
>   because there is a cycle in the constraint graph:
>     dir 0 is [/home/wesm/code/arrow/cpp/build/debug]
>     dir 1 is [/home/wesm/miniconda/envs/arrow-3.7/lib]
>       dir 2 must precede it due to runtime library [libcrypto.so.1.1]
>     dir 2 is [/home/wesm/cpp-toolchain/lib]
>       dir 1 must precede it due to runtime library [libpython3.7m.so.1.0]
>   Some of these libraries may not be found correctly.
> Call Stack (most recent call first):
>   src/arrow/CMakeLists.txt:52 (add_test_case)
>   src/arrow/python/CMakeLists.txt:139 (add_arrow_test)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to