[
https://issues.apache.org/jira/browse/ARROW-17547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607745#comment-17607745
]
Antoine Pitrou edited comment on ARROW-17547 at 9/21/22 1:16 PM:
-----------------------------------------------------------------
Another possible C++17 idiom is the [[nodiscard]] attribute. Clang-tidy has
this check
([https://releases.llvm.org/9.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/modernize-use-nodiscard.html])
and can be used to apply it automatically.
was (Author: JIRAUSER295132):
Another possible C++17 idiom is the [[nodiscard]] attribute. Clang-tidy has
this check
([https://releases.llvm.org/9.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/modernize-use-nodiscard.html)]
and can be used to apply it automatically.
> [C++] Adopt C++17 idioms and features for maintainability
> ---------------------------------------------------------
>
> Key: ARROW-17547
> URL: https://issues.apache.org/jira/browse/ARROW-17547
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: C++
> Reporter: Antoine Pitrou
> Priority: Major
> Fix For: 10.0.0
>
>
> A first version of this task was attempted one year ago in
> https://github.com/apache/arrow/pull/10414
> Possible idioms to look for:
> * {{if constexpr}} to replace SFINAE hackery
> * {{std::from_chars}} and {{std::to_chars}} to replace locale-dependent
> number parsing/formatting
> * lambda capture move-construction
> Possibly sub-tasks:
> * regenerate Flatbuffers files for C++17 (see
> {{build-support/update-flatbuffers.sh}})
> * update {{build-support/cpplint.py}} to newer upstream version
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
