Kouhei Sutou created ARROW-17868:
------------------------------------

             Summary: [C++][Python] Keep and deprecate ARROW_PYTHON CMake 
option for backward compatibility
                 Key: ARROW-17868
                 URL: https://issues.apache.org/jira/browse/ARROW-17868
             Project: Apache Arrow
          Issue Type: Improvement
          Components: C++, Python
            Reporter: Kouhei Sutou
            Assignee: Kouhei Sutou


ARROW-6858 removed {{ARROW_PYTHON}} CMake option because ARROW-16340 moved 
{{cpp/src/arrow/python/}} to {{python/pyarrow/src/}}. But it broke backward 
compatibility. Users who use {{-DARROW_PYTHON=ON}} needs to {{-DARROW_CSV=ON}}, 
{{-DARROW_DATASET=ON}} and so on manually.

See also: https://github.com/apache/arrow/pull/14224#discussion_r981399130

{quote}
FWIW this broke my local development because of no longer including those 
(although I should probably start using presets ..)

Now, it's probably fine to remove this now Python C++ has moved, but we do 
assume that some C++ modules are built on the pyarrow side (eg we assume that 
CSV is always built, while with the above change you need to ensure manually 
that this is done in your cmake call).
In any case we should update the documentation at 
https://arrow.apache.org/docs/dev/developers/python.html#build-and-test to 
indicate that there are a few components required to be able to build pyarrow.
{quote}

Eventually, we can remove {{ARROW_PYTHON}} CMake option but we should provide a 
deprecation period before we remove {{ARROW_PYTHON}}.

We should also mention that {{ARROW_PYTHON}} is deprecated in our documentation 
( https://arrow.apache.org/docs/dev/developers/python.html#build-and-test ).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to