[
https://issues.apache.org/jira/browse/ARROW-17877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610566#comment-17610566
]
Raúl Cumplido commented on ARROW-17877:
---------------------------------------
[~kou] what do you think, should we enable individually on the
verify-release-candidate.sh and other jobs all the flags that were activated
when `ARROW_PYTHON=ON` in the past if we are building pyarrow too:
{code:java}
if(ARROW_PYTHON)
set(ARROW_COMPUTE ON)
set(ARROW_CSV ON)
set(ARROW_DATASET ON)
set(ARROW_FILESYSTEM ON)
set(ARROW_HDFS ON)
set(ARROW_JSON ON)
endif() {code}
or should we create some CMake group flag that enables all the requirements for
pyarrow?
There are still quite a lot of occurrences of this flag:
{code:java}
$ grep -r "ARROW_PYTHON=ON" | wc -l
22 {code}
> [CI][Python] verify-rc python nightly builds fail due to missing some flags
> that were activated with ARROW_PYTHON=ON
> --------------------------------------------------------------------------------------------------------------------
>
> Key: ARROW-17877
> URL: https://issues.apache.org/jira/browse/ARROW-17877
> Project: Apache Arrow
> Issue Type: Bug
> Components: Continuous Integration, Python
> Reporter: Raúl Cumplido
> Assignee: Raúl Cumplido
> Priority: Blocker
> Labels: Nightly
>
> Some of our nightly builds are failing with:
> {code:java}
> [ 35%] Building CXX object CMakeFiles/_dataset.dir/_dataset.cpp.o
> /arrow/python/build/temp.linux-x86_64-cpython-38/_dataset.cpp:833:10: fatal
> error: arrow/csv/api.h: No such file or directory
> #include "arrow/csv/api.h"
> ^~~~~~~~~~~~~~~~~
> compilation terminated.{code}
> I suspect the flags included CSV=ON when building with PYTHON=ON changes here
> might be related:
> [https://github.com/apache/arrow/commit/53ac2a00aa9ff199773513f6f996f73a07b37989]
> Example of nightly failures:
> https://github.com/ursacomputing/crossbow/actions/runs/3135833175/jobs/5091988801
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
