[ 
https://issues.apache.org/jira/browse/ARROW-17904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614820#comment-17614820
 ] 

Kouhei Sutou commented on ARROW-17904:
--------------------------------------

Could you add {{PARQUET_REQUIRE_CRC32_CHECK}} or something like 
{{PARQUERT_REQUIRE_ENCRYPTION}}? (See also 
{{cpp/cmake_modules/DefineOptions.cmake}} and 
{{cpp/cmake_modules/THirdpartyToolchain.cmake}}.) If 
{{PARQUET_REQUIRE_CRC32_CHECK}} is enabled, we find zlib and enable this 
feature.

We don't want to bundle zlib's {{crc32()}} implementation. We use it as just a 
fallback implementation.

> [C++] Parquet support read page with crc32 checking
> ---------------------------------------------------
>
>                 Key: ARROW-17904
>                 URL: https://issues.apache.org/jira/browse/ARROW-17904
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Parquet
>    Affects Versions: 9.0.0
>            Reporter: Xuwei Fu
>            Assignee: Xuwei Fu
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 11.0.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently, C++'s Parquet support write page with checksum, but `ReadPage` 
> doesn't have check any checksum. And I would like to fix it
> I'd like to split this patch to different parts:
>  # Implement the crc in DataPageV1, which requires a write crc config, 
> counting crc in read mode, crc verification, migrate testing from parquet mr
>  # Implement crc in DataPageV2 and Dict



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to