[ 
https://issues.apache.org/jira/browse/ARROW-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622384#comment-17622384
 ] 

Alenka Frim commented on ARROW-18126:
-------------------------------------

This variable was added in the commit of the PyArrow refactoring:

[https://github.com/apache/arrow/pull/13311/commits/ea45ed425d65a1c46469a7fb45bcb29f2f02cacd]

and most of it was included in the test section which is now removed. The rest 
of it was in the flight section which is now changed but I haven't been able to 
found a commit at this moment.

In any case, I think this variable is not needed anymore and can be removed. 
Great catch Joris!

> [Python] ARROW_BUILD_DIR might be ignored for building pyarrow?
> ---------------------------------------------------------------
>
>                 Key: ARROW-18126
>                 URL: https://issues.apache.org/jira/browse/ARROW-18126
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Python
>            Reporter: Joris Van den Bossche
>            Priority: Major
>
> When building pyarrow, I see the following warning:
> {code}
> CMake Warning:
>   Manually-specified variables were not used by the project:
>     ARROW_BUILD_DIR
> {code}
> While we have a note in our docs 
> (https://arrow.apache.org/docs/dev/developers/python.html#build-and-test) 
> that says:
> bq. If you used a different directory name for building Arrow C++ (by default 
> it is named “build”), then you should also set the environment variable 
> {{ARROW_BUILD_DIR='name_of_build_dir'}}. This way PyArrow can find the Arrow 
> C++ built files.
> I see in the setup.py code that we check for this env variable and pass it to 
> CMake, but it's not actually used in any of the CMakeLists.txt files for 
> pyarrow.
> This might have been accidentally changed in one of the recent cmake 
> refactors? (cc [~kou] [~alenka])



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to