Weston Pace created ARROW-18133:
-----------------------------------
Summary: [C++] Update "options" handling for Substrait functions
Key: ARROW-18133
URL: https://issues.apache.org/jira/browse/ARROW-18133
Project: Apache Arrow
Issue Type: Bug
Components: C++
Reporter: Weston Pace
ARROW-17966 will adjust to the new style of options. However, many of our
existing mappings are treating options incorrectly, largely because the
Substrait function definitions changed after the mappings were added. For
example, the arithmetic functions are always looking for an "overflow" option,
even though that option is only defined for integral kernels.
For the time being, this is mostly harmless. No producers that I am aware of
specify options yet. When they do, some of these issues will probably still be
harmless. For example, it should not hurt to look for an overflow option when
it can never be defined.
However, we should do a pass through and cleanup our handling of options once
the Substrait spec has stabilized.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
