[ 
https://issues.apache.org/jira/browse/ARROW-12282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623335#comment-17623335
 ] 

Neal Richardson commented on ARROW-12282:
-----------------------------------------

Doing in ARROW-15460.

> [R] Refactor collect and compute methods
> ----------------------------------------
>
>                 Key: ARROW-12282
>                 URL: https://issues.apache.org/jira/browse/ARROW-12282
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: R
>            Reporter: Ian Cook
>            Assignee: Neal Richardson
>            Priority: Major
>
> ARROW-11754 added a {{compute()}} method which calls {{collect(as_data_frame 
> = FALSE)}}. This was a clean and simple way to add {{compute()}}, but it 
> would be more logical if {{collect()}} instead called {{compute()}}, or if 
> both called an internal function that forced computation of the lazy ops. But 
> this is complicated by the need to call {{restore_dplyr_features()}} in both 
> {{compute()}} and {{collect()}} and muddied by some uncertainty about where 
> exactly {{ensure_group_vars()}} and {{ensure_arrange_vars()}} should be 
> called. Take a closer look at this later date and consider whether to 
> refactor it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to