[
https://issues.apache.org/jira/browse/ARROW-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647959#comment-17647959
]
Yaron Gvili commented on ARROW-18371:
-------------------------------------
The discussion went beyond the current subject of `*FromJSON` - let's update
the subject or split the discussion.
I agree that `MakeBasicBatches` is not needed. While I'm less sure about
whether `BatchesWithSchema` is indeed not needed, I'll take your opinion.
Regarding random data generation, I'd prioritize having the functions; the node
could come later. Regarding the assertion macros, they are specific to `gtest`
and I'm wondering whether we could make them flexible and less opinionated -
that would be a separate issue. Note that I have my own subset of these macros
specific to `Catch2`, so this flexibility can be obtained.
> [C++] Expose *FromJSON helpers
> ------------------------------
>
> Key: ARROW-18371
> URL: https://issues.apache.org/jira/browse/ARROW-18371
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
> Reporter: Rok Mihevc
> Assignee: Bryce Mecum
> Priority: Major
> Labels: testing
>
> {Array,{{Exec,Record}Batch}FromJSON helper functions would be useful when
> testing in projects that use Arrow. BatchesWithSchema and MakeBasicBatches
> could be considered as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
