[
https://issues.apache.org/jira/browse/ARROW-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17659081#comment-17659081
]
Rok Mihevc commented on ARROW-2052:
-----------------------------------
This issue has been migrated to [issue
#18031|https://github.com/apache/arrow/issues/18031] on GitHub. Please see the
[migration documentation|https://github.com/apache/arrow/issues/14542] for
further details.
> Unify OwnedRef and ScopedRef
> ----------------------------
>
> Key: ARROW-2052
> URL: https://issues.apache.org/jira/browse/ARROW-2052
> Project: Apache Arrow
> Issue Type: Task
> Components: Python
> Affects Versions: 0.8.0
> Reporter: Antoine Pitrou
> Assignee: Antoine Pitrou
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> Currently {{OwnedRef}} and {{ScopedRef}} have similar semantics with small
> differences. Furtheremore, the naming distinction isn't obvious.
> I propose to unify them as a single {{OwnedRef}} class with the following
> characteristics:
> - doesn't take the GIL automatically
> - has a {{release()}} method that decrefs the pointer (and sets the internal
> copy to NULL) before returning it
> - has a {{detach()}} method that returns the pointer (and sets the internal
> copy to NULL) without decrefing it
> For the rare situations where an {{OwnedRef}} may be destroyed with the GIL
> released, a {{OwnedRefNoGIL}} derived class would also be proposed (the
> naming scheme follows Cython here).
> Opinions / comments?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
