[
https://issues.apache.org/jira/browse/ARROW-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rok Mihevc updated ARROW-3487:
------------------------------
External issue URL: https://github.com/apache/arrow/issues/19806
> [Gandiva] simplify NULL_IF_NULL functions that can return errors
> ----------------------------------------------------------------
>
> Key: ARROW-3487
> URL: https://issues.apache.org/jira/browse/ARROW-3487
> Project: Apache Arrow
> Issue Type: Task
> Components: C++ - Gandiva
> Reporter: Pindikura Ravindra
> Assignee: Pindikura Ravindra
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.12.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> NULL_IF_NULL functions that can return errors eg. divide currently look at
> the validity bits in each function (to avoid returning spurious errors).
>
> {code:java}
> divide(TYPE in1, boolean is_valid1, TYPE in2, boolean is_valid2, ..) {
> if (!is_valid1 || !is_valid2) {
> return 0;
> }
> if (in2 == 0) { /* set error */ }
> }
> {code}
>
> This validity check is duplicated for multiple functions and should be moved
> to the common layer (for all NULL_IF_NULL functions that can return error).
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
