[
https://issues.apache.org/jira/browse/ARROW-3906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17660930#comment-17660930
]
Rok Mihevc commented on ARROW-3906:
-----------------------------------
This issue has been migrated to [issue
#15888|https://github.com/apache/arrow/issues/15888] on GitHub. Please see the
[migration documentation|https://github.com/apache/arrow/issues/14542] for
further details.
> [C++] Break builder.cc into multiple compilation units
> ------------------------------------------------------
>
> Key: ARROW-3906
> URL: https://issues.apache.org/jira/browse/ARROW-3906
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Affects Versions: 0.11.1
> Reporter: Antoine Pitrou
> Assignee: Antoine Pitrou
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.12.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> To improve readability I suggest splitting {{builder.cc}} into independent
> compilation units. Concrete builder classes are generally independent of each
> other. The only concern is whether inlining some of the base class
> implementations is important for performance.
> This would also make incremental compilation faster when changing one of the
> concrete classes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
