[ https://issues.apache.org/jira/browse/ARROW-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17662248#comment-17662248 ]
Rok Mihevc commented on ARROW-5225: ----------------------------------- This issue has been migrated to [issue #21698|https://github.com/apache/arrow/issues/21698] on GitHub. Please see the [migration documentation|https://github.com/apache/arrow/issues/14542] for further details. > [Java] Improve performance of BaseValueVector#getValidityBufferSizeFromCount > ---------------------------------------------------------------------------- > > Key: ARROW-5225 > URL: https://issues.apache.org/jira/browse/ARROW-5225 > Project: Apache Arrow > Issue Type: Improvement > Components: Java > Reporter: Ji Liu > Assignee: Ji Liu > Priority: Trivial > Labels: pull-request-available > Fix For: 0.14.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Now in _BaseValueVector#getValidityBufferSizeFromCount_ and > _BitVectorHelper#getValidityBufferSize_, it uses _Math.ceil_ to calculate > size which is not efficient (lots of unnecessary logic in > _StrictMath#floorOrCeil_) . Since the valueCount is always not less than 0, > we could simply replace _Math.ceil_ with the following code: > _return (valueCount+7) >> 3_; -- This message was sent by Atlassian Jira (v8.20.10#820010)