[
https://issues.apache.org/jira/browse/KAFKA-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078169#comment-16078169
]
ASF GitHub Bot commented on KAFKA-5570:
---------------------------------------
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/3503
KAFKA-5570: Join request's timeout should be slightly higher than the
rebalance timeout
- Introduce per request timeouts in NetworkClient
- Use rebalanceTimeout + 5s for join request timeout
- A few minor clean-ups in NetworkClient and ConsumerNetworkClient
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka
kafka-5570-join-request-timeout-higher-than-rebalance-timeout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3503.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3503
----
commit 1a1060f3a04f9f7e376df9df953ff47d829ca076
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-07-07T14:00:44Z
Introduce per request timeouts in NetworkClient
commit 6cb76f8e73ffe13870270a93b757caf72ed43a48
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-07-07T14:07:07Z
Use rebalanceTimeout + 5s for join request timeout
commit 2dec4b149675e6158ec851b06117e606963afe49
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-07-07T14:07:39Z
A few minor clean-ups in NetworkClient and ConsumerNetworkClient
----
> Join request's timeout should be slightly higher than the rebalance timeout
> ---------------------------------------------------------------------------
>
> Key: KAFKA-5570
> URL: https://issues.apache.org/jira/browse/KAFKA-5570
> Project: Kafka
> Issue Type: Improvement
> Reporter: Ismael Juma
> Assignee: Ismael Juma
>
> This is necessary because the join request blocks until the rebalance
> completes. The join request currently uses the same timeout as other consumer
> requests and this is the reason why the default request timeout for the
> consumer is 305 seconds (while the default rebalance timeout is 300 seconds).
> This JIRA is related to KAFKA-4237, but it doesn't include the part where we
> change the default request timeout for the consumer (as that has additional
> compatibility implications and requires a KIP).
> In order to implement this, we need to add to the NetworkClient the ability
> to do per request timeouts.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
