[
https://issues.apache.org/jira/browse/KAFKA-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083753#comment-16083753
]
ASF GitHub Bot commented on KAFKA-5584:
---------------------------------------
GitHub user kongo2002 opened a pull request:
https://github.com/apache/kafka/pull/3521
KAFKA-5584: fix integer overflow in Log.size
As described in
[KAFKA-5584](https://issues.apache.org/jira/browse/KAFKA-5584) the integer
overflow in `Log.size` may lead to wrong metrics and broken size-based
retention via `log.retention.bytes` or `retention.bytes` on rather large topic
partitions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kongo2002/kafka KAFKA-5584
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3521.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3521
----
commit 4ba20618a13dfd6c16b8228b319a21ae1915e857
Author: Gregor Uhlenheuer <kongo2...@googlemail.com>
Date: 2017-07-12T10:07:49Z
KAFKA-5584: fix integer overflow in Log.size
----
> Incorrect log size for topics larger than 2 GB
> ----------------------------------------------
>
> Key: KAFKA-5584
> URL: https://issues.apache.org/jira/browse/KAFKA-5584
> Project: Kafka
> Issue Type: Bug
> Components: log
> Reporter: Gregor Uhlenheuer
> Attachments: Screen Shot 2017-07-12 at 09.10.53.png
>
>
> The {{size}} of a {{Log}} is calculated incorrectly due to an Integer
> overflow. For large topics (larger than 2 GB) this value overflows.
> This is easily observable in the reported metrics values of the path
> {{log.Log.partition.*.topic.<topicname>.Size}} (see attached screenshot).
> Moreover I think this breaks the size-based retention (via
> {{log.retention.bytes}} and {{retention.bytes}}) of large topics as well.
> I am not sure on the recommended workflow, should I open a pull request on
> github with a fix?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
