[ 
https://issues.apache.org/jira/browse/KAFKA-5629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16098230#comment-16098230
 ] 

ASF GitHub Bot commented on KAFKA-5629:
---------------------------------------

GitHub user soenkeliebau opened a pull request:

    https://github.com/apache/kafka/pull/3566

    KAFKA-5629: Added a warn message to the output of ConsoleConsumer 

    when "auto.offset.reset" property is specified on the command line but 
overridden by the code during startup. Currently the ConsoleConsumer silently 
overrides that setting, which can create confusing behavior.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soenkeliebau/kafka KAFKA-5629

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3566.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3566
    
----
commit 6416efd6cd8badf5d13228eae2f126ebf6bf1f99
Author: Soenke Liebau <soenke.lie...@opencore.com>
Date:   2017-07-24T09:08:28Z

    KAFKA-5629: Added a warn message to the output of ConsoleConsumer when 
auto.offset.reset property is specified on the command line but overridden by 
the code during startup.

----


> Console Consumer overrides auto.offset.reset property when provided on the 
> command line without warning about it.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-5629
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5629
>             Project: Kafka
>          Issue Type: Improvement
>          Components: consumer
>    Affects Versions: 0.11.0.0
>            Reporter: Sönke Liebau
>            Assignee: Sönke Liebau
>            Priority: Trivial
>
> The console consumer allows to specify consumer options on the command line 
> with the --consumer-property parameter.
> In the case of auto.offset.reset this parameter will always silently be 
> ignored though, because this behavior is controlled via the --from-beginning 
> parameter.
> I believe that behavior to be fine, however we should log a warning in case 
> auto.offset.reset is specified on the command line and overridden to 
> something else in the code to avoid potential confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to