[
https://issues.apache.org/jira/browse/KAFKA-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106435#comment-16106435
]
ASF GitHub Bot commented on KAFKA-4218:
---------------------------------------
GitHub user jeyhunkarimov opened a pull request:
https://github.com/apache/kafka/pull/3601
KAFKA-4218: Add withkey methods to KGroupedTable
This PR aims to add withKey methods to KGroupedTable interface.
This PR is part of
[KIP-149](https://cwiki.apache.org/confluence/display/KAFKA/KIP-149%3A+Enabling+key+access+in+ValueTransformer%2C+ValueMapper%2C+and+ValueJoiner).
I separated the complete PR into 4 parts as discussed in
[here](https://github.com/apache/kafka/pull/3570#issuecomment-317645747). So,
this PR concentrates on adding withKey methods to KGroupedTable interface.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeyhunkarimov/kafka KIP-149_KGroupedTable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3601.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3601
----
commit 00f10288fac503764c8c6af8ae1907864d042dae
Author: Jeyhun Karimov <je.kari...@gmail.com>
Date: 2017-07-28T23:25:59Z
Add withkey interfaces
Add withkey interfaces
Add withKey converters in AbstractStream
Add withKey interface to KGroupedTable
Remove unnecessary lines
Remove unnecessary lines
----
> Enable access to key in ValueTransformer
> ----------------------------------------
>
> Key: KAFKA-4218
> URL: https://issues.apache.org/jira/browse/KAFKA-4218
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Affects Versions: 0.10.0.1
> Reporter: Elias Levy
> Assignee: Jeyhun Karimov
> Labels: api, kip
> Fix For: 1.0.0
>
>
> While transforming values via {{KStream.transformValues}} and
> {{ValueTransformer}}, the key associated with the value may be needed, even
> if it is not changed. For instance, it may be used to access stores.
> As of now, the key is not available within these methods and interfaces,
> leading to the use of {{KStream.transform}} and {{Transformer}}, and the
> unnecessary creation of new {{KeyValue}} objects.
> KIP-149:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-149%3A+Enabling+key+access+in+ValueTransformer%2C+ValueMapper%2C+and+ValueJoiner
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
