[
https://issues.apache.org/jira/browse/KAFKA-5684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116540#comment-16116540
]
ASF GitHub Bot commented on KAFKA-5684:
---------------------------------------
GitHub user ppatierno opened a pull request:
https://github.com/apache/kafka/pull/3636
KAFKA-5684: KStreamPrintProcessor as customized KStreamPeekProcessor
This PR is intended for having KStreamPrint derived from KStreamPeek and
avoiding the "instance of" check on byte[ ] every process call.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ppatierno/kafka kafka-5684
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3636.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3636
----
commit a516a08bf22cdd53feb4ada50c73dc5a08715b74
Author: Paolo Patierno <ppatie...@live.com>
Date: 2017-08-07T12:55:16Z
Refactored KStreamPrint as derived from KStreamPeek
Removed the "instance of" check for byte[] in every KStreamPrint process,
it's up to a default mapper now
Updated KStreamPrint tests adapting to the new internal structure for
KStreamPrint and PrintForeachAction
----
> KStreamPrintProcessor as customized KStreamPeekProcessor
> --------------------------------------------------------
>
> Key: KAFKA-5684
> URL: https://issues.apache.org/jira/browse/KAFKA-5684
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Paolo Patierno
> Assignee: Paolo Patierno
> Priority: Minor
>
> Hi,
> the {{KStreamPrintProcessor}} is implemented from scratch (from the
> {{AbstractProcessor}}) and the same for the related supplier.
> It looks to me that it's just a special {{KStreamPeekProcessor}} with
> forwardDownStream to false and that allows the possibility to specify Serdes
> instances used if key/values are bytes.
> At same time used by a {{print()}} method it provides a fast way to print
> data flowing through the pipeline (while using just {{peek()}} you need to
> write the code).
> I think that it could be useful to refactoring the {{KStreamPrintProcessor}}
> as derived from the {{KStreamPeekProcessor}} customizing its behavior.
> Thanks,
> Paolo.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
