[
https://issues.apache.org/jira/browse/KAFKA-5785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141989#comment-16141989
]
ASF GitHub Bot commented on KAFKA-5785:
---------------------------------------
Github user ijuma closed the pull request at:
https://github.com/apache/kafka/pull/3734
> Always close connection if KafkaChannel.setSend throws exception
> ----------------------------------------------------------------
>
> Key: KAFKA-5785
> URL: https://issues.apache.org/jira/browse/KAFKA-5785
> Project: Kafka
> Issue Type: Bug
> Reporter: Ismael Juma
> Assignee: Ismael Juma
> Fix For: 1.0.0
>
>
> The code is currently:
> {code}
> try {
> channel.setSend(send);
> } catch (CancelledKeyException e) {
> this.failedSends.add(connectionId);
> close(channel, false);
> }
> {code}
> This is generally OK, but if another exception is thrown (typically due to a
> bug), we leak the connection.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
