[ 
https://issues.apache.org/jira/browse/KAFKA-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150295#comment-16150295
 ] 

ASF GitHub Bot commented on KAFKA-5819:
---------------------------------------

GitHub user dguy opened a pull request:

    https://github.com/apache/kafka/pull/3776

    KAFKA-5819: Add Joined class and relevant KStream join overloads

    Add the `Joined` class and the overloads to `KStream` that use it.
    Deprecate existing methods that have `Serde` params

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dguy/kafka kip-182-stream-join

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3776.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3776
    
----
commit 5be7a49c245f762479ec02c7e1625a1da882bde9
Author: Damian Guy <damian....@gmail.com>
Date:   2017-09-01T08:44:16Z

    add Joined class and overloads for KStream#join

commit d3991b13e5fd6f9c926c1d6cf3d4e15e77eea7ba
Author: Damian Guy <damian....@gmail.com>
Date:   2017-09-01T09:05:39Z

    KStream#leftJoin(KStream...)

commit d8b007304e462b7d0e59e3fb4d4f2fa10a78d05b
Author: Damian Guy <damian....@gmail.com>
Date:   2017-09-01T09:25:13Z

    stream table leftJoin

commit eeed855e153df766f1341469132f45fff62a13ce
Author: Damian Guy <damian....@gmail.com>
Date:   2017-09-01T09:40:01Z

    outerJoin

----


> Add Joined class and relevant KStream join overloads
> ----------------------------------------------------
>
>                 Key: KAFKA-5819
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5819
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: streams
>            Reporter: Damian Guy
>            Assignee: Damian Guy
>             Fix For: 1.0.0
>
>
> Add the {{Joined}} class as defined in KIP-182 and the following overloads to 
> {{KStream}}
> {code}
> <VO, VR> KStream<K, VR> join(final KStream<K, VO> other, final ValueJoiner<? 
> super V, ? super VO, ? extends VR> joiner, final JoinWindows windows, final 
> Joined<K, V, VO> options);
>  
> <VT, VR> KStream<K, VR> join(final KTable<K, VT> other, final ValueJoiner<? 
> super V, ? super VT, ? extends VR> joiner, final Joined<K, V, VT> options);
>  
> <VO, VR> KStream<K, VR> leftJoin(final KStream<K, VO> other, final 
> ValueJoiner<? super V, ? super VO, ? extends VR> joiner, final JoinWindows 
> windows, final Joined<K, V, VO> options);
>  
> <VT, VR> KStream<K, VR> leftJoin(final KTable<K, VT> other, final 
> ValueJoiner<? super V, ? super VT, ? extends VR> joiner, final Joined<K, V, 
> VT> options);
>  
> <VO, VR> KStream<K, VR> outerJoin(final KStream<K, VO> other, final 
> ValueJoiner<? super V, ? super VO, ? extends VR> joiner, final JoinWindows 
> windows, final Joined<K, V, VO> options);
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to