[
https://issues.apache.org/jira/browse/KAFKA-5820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150729#comment-16150729
]
ASF GitHub Bot commented on KAFKA-5820:
---------------------------------------
GitHub user tedyu opened a pull request:
https://github.com/apache/kafka/pull/3777
KAFKA-5820 Remove unneeded synchronized keyword in StreamThread
I removed synchronized keyword from 3 methods.
I ran the change thru streams module where test suite passed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tedyu/kafka trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3777.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3777
----
commit ef79c50e5e20236c589bbea2588fa7e11a892953
Author: tedyu <[email protected]>
Date: 2017-09-01T15:28:14Z
KAFKA-5820 Remove unneeded synchronized keyword in StreamThread
----
> Remove unneeded synchronized keyword in StreamThread
> ----------------------------------------------------
>
> Key: KAFKA-5820
> URL: https://issues.apache.org/jira/browse/KAFKA-5820
> Project: Kafka
> Issue Type: Improvement
> Reporter: Ted Yu
> Priority: Minor
>
> There are three methods in StreamThread which have unnecessary synchronized
> keyword since the variable accessed, state, is volatile :
> isRunningAndNotRebalancing
> isRunning
> shutdown
> synchronized keyword can be dropped for these methods.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
